fix(regression): Support input path globbing in Go re-write #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e passing when the fix is implemented
jsirianni
commented
May 23, 2024
| @@ -241,7 +241,7 @@ func (a *Action) Apply() error { | |||
| } | |||
There was a problem hiding this comment.
We were logging the wrong resource type here, just cosmetic.
jsirianni
commented
May 23, 2024
| @@ -491,25 +491,41 @@ func (a *Action) WriteBack() error { | |||
|
|
|||
| // decodeAnyResourceFile takes a file path and decodes it into a slice of | |||
There was a problem hiding this comment.
This is the same logic, just inside a for loop iterating over matches found by the globbing. If it is a single file without glob chars, it will just iterate once on that file.
jsirianni
commented
May 23, 2024
| @@ -522,3 +522,51 @@ func TestDecodeAnyResourceFile(t *testing.T) { | |||
| require.Contains(t, platforms, v, "Expected platform label to be one of %v, got %s", platforms, v) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
These tests failed before implementing the fix.
dsvanlani
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input file path is supported but is not working after the Go re-write v1.4.0.
Tests were added to confirm the failure, they pass now.
Re-wrote
validateFilePathsand updateddecodeAnyResourceFilefunctions to support glob matches before reading resources. The action is validation-heavy, we have two layers of protection here.filepath.Globcan return nil matches and a nil error, so we always need to check if the matches are nil. If it is, it could indicate an io error in rare cases. Glob will only return an error if the match pattern is invalid. https://pkg.go.dev/path/filepath#GlobThis change is backward compatible.
Testing
My test repo is passing, using globbing for the configuration path. https://github.com/jsirianni/bindplane-op-action-test/actions/runs/9207348741/job/25328061583
{"level":"info","time":"2024-05-23T12:05:20.990Z","msg":"Resource applied","name":"k8s-cluster","id":"k8s-cluster","kind":"Configuration","status":"unchanged"} {"level":"debug","time":"2024-05-23T12:05:20.990Z","msg":"Configuration resource added to state","name":"k8s-cluster"} {"level":"info","time":"2024-05-23T12:05:20.990Z","msg":"Applied resource","name":"k8s-cluster","status":"unchanged"} {"level":"info","time":"2024-05-23T12:05:20.990Z","msg":"Resource applied","name":"k8s-gateway","id":"k8s-gateway","kind":"Configuration","status":"unchanged"} {"level":"debug","time":"2024-05-23T12:05:20.990Z","msg":"Configuration resource added to state","name":"k8s-gateway"} {"level":"info","time":"2024-05-23T12:05:20.990Z","msg":"Applied resource","name":"k8s-gateway","status":"unchanged"} {"level":"info","time":"2024-05-23T12:05:20.990Z","msg":"Resource applied","name":"k8s-node","id":"k8s-node","kind":"Configuration","status":"unchanged"} {"level":"debug","time":"2024-05-23T12:05:20.990Z","msg":"Configuration resource added to state","name":"k8s-node"} {"level":"info","time":"2024-05-23T12:05:20.990Z","msg":"Applied resource","name":"k8s-node","status":"unchanged"} {"level":"info","time":"2024-05-23T12:05:21.174Z","msg":"No pending rollout","name":"k8s-cluster"} {"level":"info","time":"2024-05-23T12:05:21.210Z","msg":"No pending rollout","name":"k8s-gateway"} {"level":"info","time":"2024-05-23T12:05:21.245Z","msg":"No pending rollout","name":"k8s-node"}